Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for CIELAB and CIELCh #2

Closed
kdrag0n opened this issue Aug 29, 2021 · 1 comment
Closed

Add unit tests for CIELAB and CIELCh #2

kdrag0n opened this issue Aug 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@kdrag0n
Copy link
Owner

kdrag0n commented Aug 29, 2021

No description provided.

@kdrag0n kdrag0n added the enhancement New feature or request label Aug 29, 2021
@kdrag0n
Copy link
Owner Author

kdrag0n commented Sep 1, 2021

Added in v1.0.2.

@kdrag0n kdrag0n closed this as completed Sep 1, 2021
kdrag0n added a commit that referenced this issue Sep 1, 2021
@kdrag0n
tests: zcam: Add all examples from supplementary document
4c85c53 
All sample XYZ values have been adapted using colorio's implementation
of CAT02, with F values chosen to match the given surround and L_a
matching the one used for ZCAM.

The paper appears to have the wrong L_a and Y_b values for example #3.
Changing them to match #1 and #2 fixes the tests.

The paper also gives an odd value for hue angle in #5: 389.7720 degrees,
likely caused by unconditionally adding 360 to make the angle positive.
Subtracting 360 makes the test pass.

Closes #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdrag0n