Fix deadlock in NetworkLogger #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, thank you!
My plan is to synchronize the background work on a single global actor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This PR fixes a deadlock that could occur if
logTaskCreatedwas called with a task that already existed.IMO it would be best to update this code to use safer primitives like
withLock(and ultimately drop the@unchecked Sendableby using Concurrency-friendly APIs like os.OSAllocatedUnfairLock, Synchronization.Mutex, or ConcurrencyExtras.LockIsolated) — but that's a larger change so I haven't endeavored to do that atm.