Fix review comments: do a mock in unit test and make extract_RJ45_ports_index_return [] #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_index_return [] Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
keboliu
pushed a commit
that referenced
this pull request
Apr 6, 2022
…onic-net#10406) #### Why I did it To take the following into sonic-buildimage 36e1f61 API endpoints to ConfigDBConnector to support pre-loading data without blackout (sonic-net#587) [sonic-swss-common](https://github.com/Azure/sonic-swss-common) ``` 36e1f61 API endpoints to ConfigDBConnector to support pre-loading data without blackout (sonic-net#587) 556f4ad Add SAI copy action to ACL schema (sonic-net#591) db18c3a Fix bitwidth of mac address in SAI ACL schema (sonic-net#590) e9442bb [ConfigDBPipeConnector]: Added set_entry API (sonic-net#586) 6c007c0 Update README for gmock (sonic-net#562) ``` [sonic-linkmgrd](https://github.com/Azure/sonic-linkmgrd) ``` 83dfc99 Enforce uniform file/class naming convention (#52) 83004bf Shutdown ICMP heartbeats when default route state is missing and ToR is in `auto` mode (#44) b81ea31 Add `LinkProberStateMachineActiveActive` (#47) c43cf7a Decrease link probing interval after switchover to better determine the overhead of a toggle (#43) 2239fbe Enhance clang format (#46) ``` #### How I did it * Advanced submodules pointers #### How to verify it 1. make configure PLATFORM=mellanox 2. make target/sonic-mellanox.bin
keboliu
pushed a commit
that referenced
this pull request
Jun 20, 2022
[sonic-linkmgrd][202012] submodule update 3523738 Jing Zhang Sun Apr 3 20:54:40 2022 -0700 Reset link prober state when default route is back #56 8282e78 Jing Zhang Fri Apr 15 15:59:34 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown #55 (#65) 8246eb8 Jing Zhang Thu Apr 14 18:49:36 2022 -0700 Shutdown ICMP heartbeats when default route state is missing and ToR is in auto mode #44 (#59) sign-off: Jing Zhang zhangjing@microsoft.com
keboliu
pushed a commit
that referenced
this pull request
Aug 1, 2022
#### Why I did it Submodule update for sonic-dbsyncd with following change: ``` 0d67faf 2022-07-28 | Replace pyswsssdk with sonic-py-common (#45) [Hua Liu] 265c833 2022-01-11 | Updated the Azure pipeline for Code Coverage (#44) [abdosi] 6548116 2021-04-04 | [ci]: add proper azp [Guohan Lu] 43b9dab 2021-04-04 | [pytest]: add pytest.ini [Guohan Lu] ``` #### How I did it #### How to verify it #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 #### Description for the changelog Submodule update for sonic-dbsyncd with following change: ``` 0d67faf 2022-07-28 | Replace pyswsssdk with sonic-py-common (#45) [Hua Liu] 265c833 2022-01-11 | Updated the Azure pipeline for Code Coverage (#44) [abdosi] 6548116 2021-04-04 | [ci]: add proper azp [Guohan Lu] 43b9dab 2021-04-04 | [pytest]: add pytest.ini [Guohan Lu] ``` #### A picture of a cute animal (not mandatory but encouraged) Co-authored-by: liuh-80 <azureuser@liuh-dev-vm-02.5fg3zjdzj2xezlx1yazx5oxkzd.hx.internal.cloudapp.net>
keboliu
pushed a commit
that referenced
this pull request
Oct 26, 2022
… URL support "not to use cac (sonic-net#12394) he" (#45) * 4f45e3a Update gnmi_cli (#5) (#44)
keboliu
pushed a commit
that referenced
this pull request
Nov 12, 2023
…ly (sonic-net#17140) #### Why I did it src/dhcprelay ``` * 40c6877 - (HEAD -> master, origin/master, origin/HEAD) [CodeQL] fix unmet dependency for `build-swss-common` (#44) (30 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
keboliu
pushed a commit
that referenced
this pull request
Jan 3, 2024
sonic-dhcp-relay 5ae186f Yaqiang Zhu Tue Dec 19 12:05:15 2023 -0500 [counter] Clear counter table when init (#45) 40c6877 Jing Zhang Fri Nov 10 12:41:23 2023 -0800 [CodeQL] fix unmet dependency for build-swss-common (#44) sonic-dhcpmon 7c55e50 StormLiangMS Thu Sep 14 09:57:06 2023 +0800 Merge pull request #13 from jcaiMR/dev/jcai_master_interface_counter 085a087 jcaiMR Mon Sep 11 09:17:03 2023 +0000 refine counting logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)