Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to retrieve page token from page details via user token #114

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

kacurez
Copy link
Member

@kacurez kacurez commented Sep 15, 2023

fixes https://keboola.atlassian.net/browse/ST-872
Tato uprava fixuje ex facebook, kde po bc change na fb api prestali vracat fb pages v requeste pre zoznam accountov (me/accounts) z ktoreho si fb ex nacital page access token. To je reportovane ako bug ale fb sa moc nema k tomu aby to fixol vid https://developers.facebook.com/support/bugs/602264498523167/
Po novom to extractor okrem me/accounts skusa ako fallback aj cez /PAGE-ID?fields=access_token (https://developers.facebook.com/docs/pages/access-tokens), ako je poradene v tom bug reporte:
image

Test

Copy link

@pivnicek pivnicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment about something not really related

Comment on lines 32 to 33
(runtime/log-strings "Could not find page access token for" id ". Token from the configuration will be used instead.")
(runtime/log-strings "Using page access token to retrieve data for" id))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not part of the change, but isn't the second log message here a lie? the first message says that it couldn't find the page access token, and the second one says that it's using the page access token (that it couldn't find?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, actually this is if syntax of clojure, first expression in the list is if the condition passes, the second expression in the list is if the condition fails (then expression) so it is like if-then-else but the else keyword is missing here :)

@kacurez kacurez merged commit a364202 into master Sep 15, 2023
4 checks passed
@kacurez kacurez deleted the kacurez-fix-page-token-retrieval-ST-872 branch September 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants