add support for debug mode #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacurez
commented
Sep 9, 2024
| (def MAX_WAIT_TIME (* 1000 60 60 10)) | ||
| (def time-slot-ms 1000) | ||
| (def truncate 6) ; sleep for 64 seconds at most (2^6) | ||
| (def MAX_WAIT_TIME (* 1000 60 60 24)) ; poll for 24 hours at most |
There was a problem hiding this comment.
este som upravil ex backoff pre pollovanie async jobov, po novom iteruje maximalne po 60 sekundach (doteraz to bolo 0.5 sekundy) a polluje async job maximalne 24 hodin (doteraz to bolo 10 hodin). Slubujem si od toho mensiu zataz na fb api v pripade ze sa dlho polluje job (x hodin). Fb api ma moze uplatnit throtling, tak sa tomu chcem vyhnut.
eddycek
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://keboola.atlassian.net/browse/ST-2209
Tato uprava zavadza moznost zapnut
debug-mode(pod parameters).Ak je zapnuty debug-mode tak to loguje request url, status a response s tym ze access token sa z logu odstrani (nahradi slovom
TOKEN).Test ex fb with debug-mode on
Vyskusal som to tym ze som pustil extractor a vidim v logoch ze sa to loguje spravne: https://connection.eu-central-1.keboola.com/admin/projects/63/jobs/775200829
ten dlhy string co vypada ako token, nie je token ale cursor :)
Test ex fb ads async insights extraction with debug-mode on
Tu som pustil test ktory stahuje insights cez async query/job a vypada to cajk
Test without debug-mode
Spravne to neloguje nic (resp po starom) https://connection.eu-central-1.keboola.com/admin/projects/63/jobs/775202688