fix: class exports #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubMatejka
force-pushed
the
jakub-exports
branch
from
9f30fcc to
fe3f819
Compare
|
A to preslo testami na travise s tymi starymi exportami? Inak to vyzera OK. |
MiroCillik
approved these changes
Oct 9, 2018
|
Ono to projde i funguje, ale nelíbí se to Webpacku když tuhle knihovnu importuješ odjinud (almende/vis#2934). On totiž pak nemůže dělat tree shaking (nějakou tu optimalizaci importů, nebo co ;o) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jsem to sice napsal do ES6 importů, ale nechal jsem tam ES5 exporty, což se teď vůbec nelíbí Webpacku. ;o)