Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-1687 update snowflake odbc driver #1400

Merged
merged 1 commit into from
Sep 24, 2024
Merged

CT-1687 update snowflake odbc driver #1400

merged 1 commit into from
Sep 24, 2024

Conversation

jirkasemmler
Copy link
Contributor

@jirkasemmler jirkasemmler commented Sep 18, 2024 •
edited
Loading

Jira: CT-1687
KBC: https://github.com/keboola/connection/pull/5263/files (not dependent!)

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@jirkasemmler jirkasemmler added the patch backwards compatible fix label Sep 18, 2024
@jirkasemmler
Copy link
Contributor Author

nejsem si jistej tim patchem...

zajca
zajca approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@zajca zajca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

norelease, protože docker file nedistribuujeme, tomu semantic versioning odpovídá ta PHP libka, navíc sa ten odbc používá enom v testech, klient to nepoužívá

@jirkasemmler jirkasemmler added no release just test changes and removed patch backwards compatible fix labels Sep 24, 2024
@jirkasemmler jirkasemmler merged commit 1034dee into master Sep 24, 2024
4 checks passed
@jirkasemmler jirkasemmler deleted the jirka-ct-1240-test-bucket-drop branch September 24, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zajca zajca zajca approved these changes

Assignees
No one assigned
Labels
no release just test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirkasemmler @zajca