Add extra sidecar containers config for Keda operator #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
requested changes
Feb 7, 2024
lpetrazickisupgrade
force-pushed
the
lp/add-extra-containers
branch
2 times, most recently
from
d155bd7
to
cf6c7b9
Compare
JorTurFer
reviewed
Feb 7, 2024
lpetrazickisupgrade
force-pushed
the
lp/add-extra-containers
branch
from
cf6c7b9
to
2290178
Compare
JorTurFer
reviewed
Feb 9, 2024
There was a problem hiding this comment.
LGTM! Thanks for the improvement! ❤️
Is this something that could be interesting to include in our tests? You can include them modifying the values file generated during this step: https://github.com/kedacore/charts/blob/main/.github/workflows/ci-core.yml#L90
zroubalik
reviewed
Feb 12, 2024
lpetrazickisupgrade
force-pushed
the
lp/add-extra-containers
branch
from
2290178
to
3ed552a
Compare
Signed-off-by: Leo Petrazickis <lpetrazickis@upgrade.com>
lpetrazickisupgrade
force-pushed
the
lp/add-extra-containers
branch
from
3ed552a
to
d200aa6
Compare
|
@JorTurFer Sure, I've added it to the test run yaml |
JorTurFer
approved these changes
Mar 10, 2024
|
Thanks for your contribution! |
QuentinBisson
pushed a commit
to giantswarm/keda-upstream
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Leo Petrazickis <lpetrazickis@upgrade.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration parameters for specifying extra sidecar containers and extra init containers. Implements #607
Checklist
Fixes #