Create rolebinding for .Release.Namespace implicitly #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
|
I guess you could also increment patch part of the Helm chart version. |
|
i dont think this will solve the problem as the https://github.com/kedacore/charts/blob/v2.14.2/keda/templates/manager/clusterrole.yaml#L33-L40 |
…certs) Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
|
@calvinbui i think you are right, I've added this in another commit (only for the |
jkremser
commented
Jun 19, 2024
zroubalik
approved these changes
Jun 25, 2024
JorTurFer
approved these changes
Sep 2, 2024
|
How is the documentation regarding restricting access to secrets affected by #625 and this change? |
2 tasks
wozniakjan
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Create rolebinding for .Release.Namespace implicitly Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> * Operator should be able to list and watch secrets in the release ns (certs) Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> --------- Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
wozniakjan
pushed a commit
to wozniakjan/keda-charts
that referenced
this pull request
Nov 28, 2024
* Create rolebinding for .Release.Namespace implicitly Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> * Operator should be able to list and watch secrets in the release ns (certs) Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> --------- Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When helm chart is installed with a non-empty
watchNamespacefield, it will create theRoleBindingresource for the cluster role that contains most of the operator rights for each specified namespace in this CSV field. However, not for the namespace into which we actually install KEDA (mostly calledkeda).So this PR adds the
.Release.Namespaceto the listChecklist
Fixes #641