Skip to content

Commit

Permalink
Prepare v0.8.0 (#1010)
Browse files Browse the repository at this point in the history
* Prepare v0.8.0

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* rebase main branch

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* move add-in installation to the end of setup to remove noise on logs

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Apply suggestions from code review

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

---------

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
  • Loading branch information
JorTurFer and tomkerkhove committed May 2, 2024
1 parent 38f50bf commit 1c9f734
Show file tree
Hide file tree
Showing 15 changed files with 48 additions and 73 deletions.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/2_bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ body:
label: "HTTP Add-on Version"
description: "What version of the KEDA HTTP Add-on are you running?"
options:
- "0.8.0"
- "0.7.0"
- "0.6.0"
- "0.5.0"
Expand Down
30 changes: 24 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ This changelog keeps track of work items that have been completed and are ready
## History

- [Unreleased](#unreleased)
- [v0.8.0](#v080)
- [v0.7.0](#v070)
- [v0.6.0](#v060)
- [v0.5.0](#v050)
Expand All @@ -22,14 +23,33 @@ This changelog keeps track of work items that have been completed and are ready

### New

- **General**: Add support to collect metrics using either a prometheus compatible endpoint or by sending metrics to an OTEL http endpoint ([#910](https://github.com/kedacore/http-add-on/issues/910))
- **General**: Propagate HTTPScaledObject labels and annotations to ScaledObject ([#840](https://github.com/kedacore/http-add-on/issues/840))
- **General**: Provide support to allow HTTP scaler to work alongside other core KEDA scalers ([#489](https://github.com/kedacore/http-add-on/issues/489))
- **General**: Support aggregation windows ([#882](https://github.com/kedacore/http-add-on/issues/882))
- **General**: TODO ([#TODO](https://github.com/kedacore/http-add-on/issues/TODO))

### Improvements

- **General**: TODO ([#TODO](https://github.com/kedacore/http-add-on/issues/TODO))

### Fixes

- **General**: TODO ([#TODO](https://github.com/kedacore/http-add-on/issues/TODO))

### Deprecations

- **General**: TODO ([#TODO](https://github.com/kedacore/http-add-on/issues/TODO))

### Other

- **General**: TODO ([#TODO](https://github.com/kedacore/http-add-on/issues/TODO))

## v0.8.0

### New

- **General**: Add configurable TLS on the wire support to the interceptor proxy ([#907](https://github.com/kedacore/http-add-on/issues/907))
- **General**: Add support for collecting metrics using a Prometheus compatible endpoint or by sending metrics to an OpenTelemetry's HTTP endpoint ([#910](https://github.com/kedacore/http-add-on/issues/910))
- **General**: Propagate HTTPScaledObject labels and annotations to ScaledObject ([#840](https://github.com/kedacore/http-add-on/issues/840))
- **General**: Provide support for allowing HTTP scaler to work alongside other core KEDA scalers ([#489](https://github.com/kedacore/http-add-on/issues/489))
- **General**: Support aggregation windows ([#882](https://github.com/kedacore/http-add-on/issues/882))

### Fixes

Expand All @@ -39,8 +59,6 @@ This changelog keeps track of work items that have been completed and are ready

You can find all deprecations in [this overview](https://github.com/kedacore/http-add-on/labels/breaking-change) and [join the discussion here](https://github.com/kedacore/http-add-on/discussions/categories/deprecations).

- **General**: Deprecated `.spec.scaleTargetRef.deployment` ([#960](https://github.com/kedacore/http-add-on/discussions/960))
- **General**: Deprecated `KEDA_HTTP_DEPLOYMENT_CACHE_POLLING_INTERVAL_MS` in favor of `KEDA_HTTP_ENDPOINTS_CACHE_POLLING_INTERVAL_MS` ([#438](https://github.com/kedacore/http-add-on/issues/438))
- **General**: Deprecated `targetPendingRequests` in favor of `spec.scalingMetric.*.targetValue` ([#959](https://github.com/kedacore/http-add-on/discussions/959))

### Other
Expand Down
20 changes: 5 additions & 15 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -176,22 +176,22 @@ deploy: manifests kustomize ## Deploy to the K8s cluster specified in ~/.kube/co
$(KUSTOMIZE) edit set image ghcr.io/kedacore/http-add-on-interceptor=${IMAGE_INTERCEPTOR_VERSIONED_TAG}

cd config/interceptor && \
$(KUSTOMIZE) edit add patch --path e2e-test/deployment.yaml --group apps --kind Deployment --name interceptor --version v1
$(KUSTOMIZE) edit add patch --path e2e-test/otel/deployment.yaml --group apps --kind Deployment --name interceptor --version v1

cd config/interceptor && \
$(KUSTOMIZE) edit add patch --path e2e-test/scaledobject.yaml --group keda.sh --kind ScaledObject --name interceptor --version v1alpha1
$(KUSTOMIZE) edit add patch --path e2e-test/otel/scaledobject.yaml --group keda.sh --kind ScaledObject --name interceptor --version v1alpha1

cd config/interceptor && \
$(KUSTOMIZE) edit add patch --path tls/deployment.yaml --group apps --kind Deployment --name interceptor --version v1
$(KUSTOMIZE) edit add patch --path e2e-test/tls/deployment.yaml --group apps --kind Deployment --name interceptor --version v1

cd config/interceptor && \
$(KUSTOMIZE) edit add patch --path tls/proxy.service.yaml --kind Service --name interceptor-proxy --version v1
$(KUSTOMIZE) edit add patch --path e2e-test/tls/proxy.service.yaml --kind Service --name interceptor-proxy --version v1

cd config/scaler && \
$(KUSTOMIZE) edit set image ghcr.io/kedacore/http-add-on-scaler=${IMAGE_SCALER_VERSIONED_TAG}

cd config/scaler && \
$(KUSTOMIZE) edit add patch --path e2e-test/deployment.yaml --group apps --kind Deployment --name scaler --version v1
$(KUSTOMIZE) edit add patch --path e2e-test/otel/deployment.yaml --group apps --kind Deployment --name scaler --version v1

cd config/operator && \
$(KUSTOMIZE) edit set image ghcr.io/kedacore/http-add-on-operator=${IMAGE_OPERATOR_VERSIONED_TAG}
Expand All @@ -200,13 +200,3 @@ deploy: manifests kustomize ## Deploy to the K8s cluster specified in ~/.kube/co

undeploy:
$(KUSTOMIZE) build config/default | kubectl delete -f -

kind-load:
kind load docker-image ghcr.io/kedacore/http-add-on-operator:${VERSION}
kind load docker-image ghcr.io/kedacore/http-add-on-interceptor:${VERSION}
kind load docker-image ghcr.io/kedacore/http-add-on-scaler:${VERSION}

k3d-import:
k3d image import ghcr.io/kedacore/http-add-on-operator:main
k3d image import ghcr.io/kedacore/http-add-on-interceptor:main
k3d image import ghcr.io/kedacore/http-add-on-scaler:main
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
23 changes: 0 additions & 23 deletions config/interceptor/otel/deployment.yaml

This file was deleted.

5 changes: 0 additions & 5 deletions config/interceptor/otel/kustomization.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions config/interceptor/otel/scaledobject.yaml

This file was deleted.

File renamed without changes.
File renamed without changes.
36 changes: 18 additions & 18 deletions tests/utils/setup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,24 +172,6 @@ func TestSetupKEDA(t *testing.T) {
"replica count should be 1 after 3 minutes")
}

func TestSetupTLSConfiguration(t *testing.T) {
out, err := ExecuteCommandWithDir("make test-certs", "../..")
require.NoErrorf(t, err, "error generating test certs - %s", err)
t.Log(string(out))
t.Log("test certificates successfully generated")

_, err = ExecuteCommand("kubectl -n keda create secret tls keda-tls --cert ../../certs/tls.crt --key ../../certs/tls.key")
require.NoErrorf(t, err, "could not create tls cert secret in keda namespace - %s", err)
}

func TestDeployKEDAHttpAddOn(t *testing.T) {
out, err := ExecuteCommandWithDir("make deploy", "../..")
require.NoErrorf(t, err, "error deploying KEDA Http Add-on - %s", err)

t.Log(string(out))
t.Log("KEDA Http Add-on deployed successfully using 'make deploy' command")
}

func TestSetupOpentelemetryComponents(t *testing.T) {
OpentelemetryNamespace := "open-telemetry-system"
otlpTempFileName := "otlp.yml"
Expand Down Expand Up @@ -220,3 +202,21 @@ func TestSetupOpentelemetryComponents(t *testing.T) {
_, err = ExecuteCommand(fmt.Sprintf("kubectl apply -f %s -n %s", otlpServiceTempFileName, OpentelemetryNamespace))
require.NoErrorf(t, err, "cannot update opentelemetry ports - %s", err)
}

func TestSetupTLSConfiguration(t *testing.T) {
out, err := ExecuteCommandWithDir("make test-certs", "../..")
require.NoErrorf(t, err, "error generating test certs - %s", err)
t.Log(string(out))
t.Log("test certificates successfully generated")

_, err = ExecuteCommand("kubectl -n keda create secret tls keda-tls --cert ../../certs/tls.crt --key ../../certs/tls.key")
require.NoErrorf(t, err, "could not create tls cert secret in keda namespace - %s", err)
}

func TestDeployKEDAHttpAddOn(t *testing.T) {
out, err := ExecuteCommandWithDir("make deploy", "../..")
require.NoErrorf(t, err, "error deploying KEDA Http Add-on - %s", err)

t.Log(string(out))
t.Log("KEDA Http Add-on deployed successfully using 'make deploy' command")
}

0 comments on commit 1c9f734

Please sign in to comment.