-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Docker images to ghcr.io/kedacore/http-add-on/* #567
Comments
I'm not 100% sure if GH supports the extra segment (I think so), but dockerhub doesn't support it, Contributors who are working in the repo and need to publish their images can't do |
Yes, you can definitely do this in GHCR. I personally think it's worth the change to provide some structure but it's not a must. @kedacore/keda-maintainers @kedacore/keda-http-maintainers ? |
We can do it if there isn't any objection, my only concern is about developing experience, but I can think about how to make it easier. Next week I'll take a look |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
I wouldn't do this change personally, we don't do this for core images so I don't see much benefits in here, the prefix is there and I am not sure if the change in one character is wort the additional problems, which may be introduced by this change. |
Agreed |
Closing. |
As of today, our images are structured as following:
![image](https://user-images.githubusercontent.com/4345663/211252336-7d9f8cf3-38b8-4726-8f8b-79eb2f75dc57.png)
Which you can pull through:
However, I'm wondering if we should change them to the following before v1.0:
The text was updated successfully, but these errors were encountered: