Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build an extra docker tag with commit sha #596

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 2, 2023

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

This PR includes a new tag based on the git SHA for having the option of using a specific image from canary

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Changelog has been updated and is aligned with our changelog requirements

Related to #567

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner February 2, 2023 19:46
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title feat: rename docker images and add sha tag feat: build an extra docker tag with commit sha Feb 3, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Changelog.md Outdated Show resolved Hide resolved
Changelog.md Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

@tomkerkhove PTAL

@JorTurFer JorTurFer enabled auto-merge (squash) February 6, 2023 13:18
@JorTurFer JorTurFer merged commit 8b1df1f into kedacore:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants