-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename keda-http-add-on-interceptor-proxy to keda-add-ons-http-interceptor-proxy #1037
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR 😄 This behaviour is documented here: https://github.com/kedacore/http-add-on/blob/main/docs/walkthrough.md#routing-to-the-right-service Personally I'd prefer to wait until going to GA, but maybe @zroubalik and @tomkerkhove have other opinion |
I was doing a TUTORIAL today and thought I couldn't connect, but now that you mention it I understand everything. |
Should we abandon the PR then? |
I think users will be happier if it is merged because it doesn't actually work regardless of the warnings, but it depends on the project's policy, so if it is not acceptable, it can be discarded. |
We should use one naming, regardles what was the installation method, but I would use |
d9224b5
to
362d5d1
Compare
@zroubalik Is this correct? |
thank you @kahirokunn, I like your PR very much! tbh, I also got a bit confused initially by the discrepancy in naming. I accepted that as a quirky behaviour of the chart and accepted that as is, but unifying the names regardless of the installation method would make me happier :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would also need to consolidate stuff in the Helm chart: https://github.com/kedacore/charts/tree/main/http-add-on
Let's see what @JorTurFer thinks
Thank you LGTM! |
I see the benefit of unifying them, but I'm afraid about the impact. |
I see the point, but I think the sooner we do the change the lesser impact, also this is still in beta, so we can do any breaking changes. Users will just need to migrate to the new version. |
Yes, totally. My point is that ScalingSet feature can offer an smooth migration path as they can just deploy their new ScalingSet and migrate the workloads to it as they can have both in parallel. Currently, they need to deploy another HTTP Add-on (all the components) temporally. |
Yes, so that's another incetive for you to complete ScalingSets ASAP :)) So let's try to merge this once ScalingSets are completed. I think the benefits are clera, let's use same naming for all methods etc. As I mentioned, I would prefer if we use I would not keep both names in the charts, they would become too complex and confusing imho. @JorTurFer how does that sound to you? |
lol, no pressure xD
My point is that ScalingSets feature has to be merged and released (so this PR can be merged for v0.10.0 or so)
I prefer this name too, I don't like the other naming at all, but 🤷 xD |
Are you sure? 😄 |
Go Bold 👍 |
19fb6a1
to
bdb592b
Compare
…nterceptor-proxy Source: https://github.com/kedacore/charts/blob/main/http-add-on/Chart.yaml#L3 Signed-off-by: kahirokunn <okinakahiro@gmail.com>
…nterceptor-proxy Signed-off-by: kahirokunn <okinakahiro@gmail.com>
bdb592b
to
8643312
Compare
Renamed
keda-http-add-on-interceptor-proxy
tokeda-add-ons-http-interceptor-proxy
to align with naming conventions as referenced in the source: https://github.com/kedacore/charts/blob/main/http-add-on/Chart.yaml#L3Checklist
README.md
docs/
directoryFixes #