Adding GOOS and GOARCH to the Dockerfiles #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
requested review from
ahmelsayed,
tomkerkhove and
zroubalik
as code owners
arschles
added
bug
ajanth97
approved these changes
Jun 18, 2021
khaosdoctor
approved these changes
Jun 30, 2021
tomkerkhove
approved these changes
Jul 1, 2021
arschles
added a commit
to arschles/http-add-on
that referenced
this pull request
Aug 18, 2021
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that all Go binaries are built inside Docker images with
GOOSandGOARCHenv variables set. They default toGOOS=linuxandGOARCH=amd64but can be overridden via docker build argumentsChecklist
README.mddocs/Fixes #185