generated from kedacore/github-template
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring concurrency in scaler's pending HTTP queue fetcher logic #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
cc/ @asw101 |
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
…-add-on into request-counts-concurrency
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
…erver Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
…equest-counts-concurrency Signed-off-by: Aaron <aaron@ecomaz.net>
bketelsen
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…equest-counts-concurrency Signed-off-by: Aaron <aaron@ecomaz.net>
Thanks @bketelsen ! Although the linkinator CI check is failing, I'm going to merge this anyway. The failure is due to kedacore/keda#2215, and the work to fix it will be done separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the
queuePinger
'srequestCounts
function in the scaler. Highlights:requestCounts
tofetchAndSaveCounts
fetchCounts
function (not method on thequeuePinger
) that does all the heavy liftingfetchAndSaveCounts
to simply callfetchCounts
and save the results internally to thequeuePinger
fetchCounts
fetchCounts
returnsChecklist
README.md
docs/
directoryFixes #286
Fixes #139