Beginning to write tests #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref kedacore#13 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
requested review from
ahmelsayed,
tomkerkhove and
zroubalik
as code owners
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
…on into tests Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
added a commit
that referenced
this pull request
Feb 26, 2021
* Improve status conditions Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * refactoring typed Kubernetes clients out Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * finishing delete logic Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing now-unused code Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing commented unused code Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * fixing lint error Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * Delete test file PR #43 will address it Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Update deployment client Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Update scaled object client Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Add fix notation Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Move FIX to TODO Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Add context to requestCounts Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Adding an FAQ (#71) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com> Approved-at: Aaron Schlesinger <aaron@ecomaz.net> * Remove unused code Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Use two strings as opposed to interface Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Revert "Delete test file" This reverts commit 46f4de7. Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com> Approved-at: Aaron Schlesinger <aaron@ecomaz.net> * Restore pkg/k8s/client.go Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com> Approved-at: Aaron Schlesinger <aaron@ecomaz.net> * Add context to queue pinger Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> * Adding an FAQ (#71) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com> Approved-at: Aaron Schlesinger <aaron@ecomaz.net> * Revert "Delete test file" This reverts commit 46f4de7. Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com> Approved-at: Aaron Schlesinger <aaron@ecomaz.net> * Restore pkg/k8s/client.go Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com> Approved-at: Aaron Schlesinger <aaron@ecomaz.net> * Add context to queue pinger Signed-off-by: Lucas Santos <lhs.santoss@gmail.com> Co-authored-by: Aaron Schlesinger <aaron@ecomaz.net> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to structure and write tests. It's not intended to build all of them.
Checklist
Ref #13