-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use registry.k8s.io/e2e-test-images/agnhost
instead of arschles/xkcd
#693
Conversation
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
What about using |
There's also the new |
I didn't know about that, I'm going to take a look ❤️ |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
ghcr.io/kedacore/http-add-on-demo-server
image and use itregistry.k8s.io/e2e-test-images/agnhost
instead of arschles/xkcd
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
PTAL @t0rr3sp3dr0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, we are using
arschles/xkcd
as docker image. This image isn't under our control and it doesn't support ARM64. As we support ARM64 arch.As there is an image in Kubernetes registry for e2e tests which matches are requirements and it's multi arch, this PR replaces them
Checklist
Fixes #665