Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min and max replicas #85

Merged
merged 13 commits into from
Mar 15, 2021
Merged

Add min and max replicas #85

merged 13 commits into from
Mar 15, 2021

Conversation

khaosdoctor
Copy link
Contributor

Adds new API to provide min and max replicas to scaledobjects

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • A PR is opened to update the documentation on our docs repo

Fixes #62

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @khaosdoctor, one request only

operator/controllers/config/app_info.go Outdated Show resolved Hide resolved
khaosdoctor and others added 3 commits March 11, 2021 15:21
Signed-off-by: Lucas Santos <hello@lsantos.dev>
Signed-off-by: Lucas Santos <hello@lsantos.dev>
Signed-off-by: Lucas Santos <hello@lsantos.dev>
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this one

Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @khaosdoctor !

@arschles arschles merged commit 269d17c into kedacore:main Mar 15, 2021
kingdonb pushed a commit to kingdonb/http-add-on that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose min and max replicas on the HTTPScaledObject
3 participants