-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min and max replicas #85
Conversation
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @khaosdoctor, one request only
Signed-off-by: Lucas Santos <hello@lsantos.dev>
Signed-off-by: Lucas Santos <hello@lsantos.dev>
Signed-off-by: Lucas Santos <hello@lsantos.dev>
Signed-off-by: Lucas Santos <hello@lsantos.dev>
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
kind: CustomResourceDefinition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @khaosdoctor !
Create resource cluster-01
Adds new API to provide min and max replicas to scaledobjects
Checklist
Fixes #62