Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaledobject name needs to be part of the query for metrics #1037

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates: kedacore/keda#4088

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik requested a review from a team as a code owner January 12, 2023 12:41
@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit ec1edb3
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63c0026cc228b9000839dad7
😎 Deploy Preview https://deploy-preview-1037--keda.netlify.app/docs/2.10/operate/metrics-server
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Update also v2.10 please

@zroubalik
Copy link
Member Author

LGTM! Update also v2.10 please

🤦

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
Copy link
Member Author

@JorTurFer fixed, good catch

@JorTurFer JorTurFer merged commit fcb6135 into kedacore:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants