Added redis lag docs #1147
Merged
Added redis lag docs #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mikelam-us <michael.lam@aixplain.com>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
krishnadurai
reviewed
Jun 7, 2023
There was a problem hiding this comment.
@mikelam-us the changes look good to me. A few points to note:
- Please mention that the lag parameter is only compatible with Redis 0.7 + version servers!
- The lag configuration is the only configuration that enables scaling down to 0.
Signed-off-by: mikelam-us <michael.lam@aixplain.com>
|
@mikelam-us Can you please link the related issue/PR please? I need a bit more context on this |
|
@tomkerkhove |
|
Thanks, updated PR and will wait until your feedback is incorporated |
JorTurFer
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Could you update standalone documentation as well?
https://github.com/kedacore/keda-docs/blob/main/content/docs/2.11/scalers/redis-streams.md
Signed-off-by: mikelam-us <michael.lam@aixplain.com>
zroubalik
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes:
Relates to kedacore/keda#3127
Relates to kedacore/keda#4592