-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Provide valid syntax for PostgreSQL queries #1282
Conversation
Signed-off-by: Manish Kumar Mourya <135261699+M4nihere@users.noreply.github.com>
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello @M4nihere , I have a question, is the semicolon required or just for styling? I'm checking current e2e test and it doesn't have it |
Yes, there is always semicolon required at the end of a postgresql query, if you don't use semicolon the query will not return any value. |
lol, I don't know how KEDA does the magic but it works without it (but I agree with adding it if it's the standard). |
I myself have tested it on Keda ScaledObject with airflow. Thanks !! |
Yeah, don't worry. I've tested with latest KEDA version and maybe something has changed, but in any case it works too, so we can add the semicolon to docs, np |
Yes, I can do that but as you have mentioned in some Keda version it worked without semicolon, however I'm not sure how did that worked but I won't be able to test every Keda Version. Because I'm using This version that's why I've found that bug. |
Let's update all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M4nihere thanks! Could you please fix this also for the other versions (including 2.13)?
Signed-off-by: Manish Kumar Mourya <135261699+M4nihere@users.noreply.github.com>
@JorTurFer Just updated the 2.13 !! |
@JorTurFer Are you going to merge this pull request ? |
Could you update older versions please? Then we can merge this :) |
Sure @JorTurFer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Mind updating all versions please?
Hi @JorTurFer |
Signed-off-by: Mani <mani@Manis-MacBook-Pro.local>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
This is just stylistic btw. A semi colon is required when using And you could make the argument that it's possible harmful in KEDA as it might mistakenly lead users to think they could issue multiple queries when only one will work. |
There was a missing ";" in the triggers.metadata.query
Checklist
Fixes #
Just had to add a semicolon ";" at the end of the query.