Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add documentation for metric-scaler-format #1325

Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat: add documentation for metric-scaler-format #1325

merged 3 commits into from
Mar 25, 2024

Conversation

fira42073
Copy link
Contributor

Provide a description of what has been changed
Added detailed description for metric scaler format.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes keda/#2633

@fira42073 fira42073 requested a review from a team as a code owner March 1, 2024 12:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 1c9d3b7
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6601449194dcc30008a5fc34
😎 Deploy Preview https://deploy-preview-1325--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fira42073 fira42073 mentioned this pull request Mar 1, 2024
Merged
5 tasks
@fira42073
feat: add documentation for metric-scaler-format
49d9ea6 
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
@fira42073 fira42073 force-pushed the metric-scaler-format branch from ca2e91f to 49d9ea6 Compare March 22, 2024 15:51
@fira42073
Copy link
Contributor Author

@zroubalik @wozniakjan

This can be merged too if all looks well
it's update of documentation for kedacore/keda#2633

@fira42073 fira42073 mentioned this pull request Mar 25, 2024
Closed
fira42073 and others added 2 commits March 25, 2024 10:26
@fira42073 @wozniakjan
Update content/docs/2.14/scalers/metrics-api.md
823da03 
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Murr Kyuri <39532283+Friedrich42@users.noreply.github.com>
add examples
1c9d3b7 
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
@JorTurFer JorTurFer merged commit 7efac8e into kedacore:main Mar 25, 2024
8 checks passed
@fira42073 fira42073 deleted the metric-scaler-format branch March 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan Awaiting requested review from wozniakjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics API Scaler support different format
3 participants
@fira42073 @wozniakjan @JorTurFer