Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: MongoDB scaler add scheme field description #1326

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Feat: MongoDB scaler add scheme field description #1326

merged 1 commit into from
Mar 12, 2024

Conversation

tico88612
Copy link
Contributor

MongoDB scaler added scheme field description for support MongoDB SRV record.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related keda #5544

@tico88612 tico88612 requested a review from a team as a code owner March 1, 2024 17:14
@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 7a43883
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65e2116c7b36580008bf31ab
😎 Deploy Preview https://deploy-preview-1326--keda.netlify.app/docs/2.14/scalers/mongodb
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tico88612 tico88612 mentioned this pull request Mar 1, 2024
Merged
4 tasks
JorTurFer
JorTurFer reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

content/docs/2.14/scalers/mongodb.md Outdated Show resolved Hide resolved
content/docs/2.14/scalers/mongodb.md Outdated Show resolved Hide resolved
@tico88612
Feat: MongoDB scaler add scheme field description
7a43883 
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/mongodb-scaler-add-scheme branch from 8fe4743 to 7a43883 Compare March 1, 2024 17:33
@tico88612 tico88612 requested a review from JorTurFer March 1, 2024 17:34
@JorTurFer JorTurFer merged commit 5d5ecc9 into kedacore:main Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tico88612 @JorTurFer