-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queueLengthStrategy option to azure-storage-queue scaler. #1406
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -26,6 +27,7 @@ triggers: | |||
|
|||
- `queueName` - Name of the queue. | |||
- `queueLength` - Target value for queue length passed to the scaler. Example: if one pod can handle 10 messages, set the queue length target to 10. If the actual number of messages in the queue is 30, the scaler scales to 3 pods. (Default: `5`, Optional) | |||
- `queueLengthStrategy` - `default` considers both visible and invisible messages, while `visibleonly` uses Peek to count only visible messages. In `visibleonly`, if the count of messages is 32 or higher, it falls back to the default strategy, counting both visible and invisible messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is not really clarifying what it includes. Instead I would propose to call it all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please align with the "(Default: 5
, Optional)" convention as per https://github.com/kedacore/keda-docs#writing-documentation-for-a-scaler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Hope this version is better?
Can you fix the DCO issues please? You can learn more in our contribution guide. |
ab99319
to
5ffdeb4
Compare
Signed-off-by: Leonardo D'Ippolito <contact@leodip.com>
5ffdeb4
to
316d648
Compare
DCO fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for feature to merge first
…re#1406) Signed-off-by: Leonardo D'Ippolito <contact@leodip.com> Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
This adds documentation about the new
queueLengthStrategy
configuration option for the Azure Storage Queue scaler.Related to kedacore/keda#4478