Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update IBM MQ scaler docs for TLS support #1433

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Jul 23, 2024

Adding support to enable authentication with TLS certs within the existing IBM MQ scaler by extending it, with additional optional parameters.

Currently, MQ appliance is expecting the Basic Auth credentials as well along with certificates. The change is therefore made in such a way that Basic Auth remains necessary if you also provide a TLS certificate.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes: 5974

Signed-off-by: rickbrouwer <75609067+rickbrouwer@users.noreply.github.com>
@rickbrouwer rickbrouwer requested a review from a team as a code owner July 23, 2024 14:08
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit a842b3a
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/669fb952bcedee0008348103
😎 Deploy Preview https://deploy-preview-1433--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer JorTurFer merged commit 50379f6 into kedacore:main Jul 25, 2024
8 checks passed
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Aug 5, 2024
Signed-off-by: rickbrouwer <75609067+rickbrouwer@users.noreply.github.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IBM MQ TLS auth
2 participants