Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CloudEventList with ScaledJob type #1457

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Update CloudEventList with ScaledJob type #1457

merged 1 commit into from
Aug 19, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Aug 19, 2024 •
edited by tomkerkhove
Loading

Update CloudEventList with ScaledJob type

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3523
Relates to kedacore/keda#6072

@SpiritZhou
Update
aef9d8d 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner August 19, 2024 07:41
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit aef9d8d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66c2f71f9bc1c20008a6ca37
😎 Deploy Preview https://deploy-preview-1457--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tomkerkhove
tomkerkhove approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting to merge until feature is merged

@JorTurFer JorTurFer merged commit ca51fd4 into kedacore:main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritZhou @tomkerkhove @JorTurFer