Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] adds doc for consumer offset reset policy option to keda kafka scaler #206

Merged

Conversation

grassiale
Copy link
Contributor

Signed-off-by: grassiale alessandro.grassi01@gmail.com

This is related to pr: kedacore/keda#925

@zroubalik
Copy link
Member

zroubalik commented Jul 10, 2020

As mentioned in the PR kedacore/keda#925, we would like to include this change into upcoming v2. Could you please update this PR and put the change only into content/docs/2.0/scalers/apache-kafka.md?

Signed-off-by: grassiale <alessandro.grassi01@gmail.com>
@grassiale grassiale force-pushed the feature/kafka-scaler-offset-reset-policy branch from 79eaed2 to fd57760 Compare July 10, 2020 10:05
content/docs/2.0/scalers/apache-kafka.md Outdated Show resolved Hide resolved
content/docs/2.0/scalers/apache-kafka.md Outdated Show resolved Hide resolved
content/docs/2.0/scalers/apache-kafka.md Outdated Show resolved Hide resolved
content/docs/2.0/scalers/apache-kafka.md Outdated Show resolved Hide resolved
@grassiale grassiale changed the title adds doc for consumer offset reset policy option to keda kafka scaler [v2] adds doc for consumer offset reset policy option to keda kafka scaler Jul 12, 2020
…ining why in brief comment.

Signed-off-by: grassiale <alessandro.grassi01@gmail.com>
@grassiale grassiale force-pushed the feature/kafka-scaler-offset-reset-policy branch from 3aa42ea to 5cdeb80 Compare July 13, 2020 09:36
Signed-off-by: grassiale <alessandro.grassi01@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 4fa44cf into kedacore:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants