-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM MQ scaler doc #283
IBM MQ scaler doc #283
Conversation
Add ibm mq docs
Merge with master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just a few remarks.
Update trigger parameters
Signed-off-by: cpilton <pilton.callum@gmail.com>
Signed-off-by: cpilton <pilton.callum@gmail.com>
Signed-off-by: cpilton <pilton.callum@gmail.com>
Fix suggestions made in PR
IBM Copyright and Apache 2.0 comments removed from file headers at the request of the KEDA project so that our contribution presents consistently with the wider codebase ‘house style’. In accordance with the KEDA and CNCF contribution guidelines, IBM copyright is unaffected and this contribution is made under Apache 2.0 license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the open topics
Allow username/password from env & Move parameter list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As outlined in issue 1253 this PR contains documentation for our IBM MQ scaler.