Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM MQ scaler doc #283

Merged
merged 14 commits into from
Oct 23, 2020
Merged

IBM MQ scaler doc #283

merged 14 commits into from
Oct 23, 2020

Conversation

NisheekaNynan1
Copy link
Contributor

As outlined in issue 1253 this PR contains documentation for our IBM MQ scaler.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few remarks.

content/docs/2.0/scalers/ibm-mq.md Outdated Show resolved Hide resolved
content/docs/2.0/scalers/ibm-mq.md Outdated Show resolved Hide resolved
content/docs/2.0/scalers/ibm-mq.md Show resolved Hide resolved
cpilton and others added 6 commits October 15, 2020 15:29
Update trigger parameters
Signed-off-by: cpilton <pilton.callum@gmail.com>
Signed-off-by: cpilton <pilton.callum@gmail.com>
Signed-off-by: cpilton <pilton.callum@gmail.com>
Fix suggestions made in PR
@cpilton
Copy link
Contributor

cpilton commented Oct 23, 2020

IBM Copyright and Apache 2.0 comments removed from file headers at the request of the KEDA project so that our contribution presents consistently with the wider codebase ‘house style’. In accordance with the KEDA and CNCF contribution guidelines, IBM copyright is unaffected and this contribution is made under Apache 2.0 license.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the open topics

content/docs/2.0/scalers/ibm-mq.md Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 8cd2993 into kedacore:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants