-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add checkpointStrategy parameter to event-hub #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think @zroubalik ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good, I have added a minor corrections wrt formatting.
And I'd reformat the checkpointStrategy
options to start with lowercase, so it is consistent with the rest of the spec.
Signed-off-by: Christian Leinweber <christian.leinweber@maibornwolff.de>
I've add more details to the parameter list. additionally i found out there are also 2 implementations for C#. I have tested both, and the behavior is like Python and Java. One Implementation based on the EventProcessorHost and a new one, which is called EventProcessorClient. The EventProcessorHost works with the default path(no checkpointStrategy specified), the EventProcessorClient with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few tweaks!
…on event-hub Signed-off-by: Christian Leinweber <christian.leinweber@maibornwolff.de>
Thank you! |
Signed-off-by: Christian Leinweber christian.leinweber@maibornwolff.de