Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce: rolloutStrategy #563

Merged
merged 3 commits into from
Nov 1, 2021
Merged

introduce: rolloutStrategy #563

merged 3 commits into from
Nov 1, 2021

Conversation

etamarw
Copy link
Contributor

@etamarw etamarw commented Oct 30, 2021 •
edited by zroubalik
Loading

Signed-off-by: etamarw etamarw@wix.com

add rolloutStrategy to the scaledjob docs.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@etamarw
introduce: rolloutStrategy
2812535 
Signed-off-by: etamarw <etamarw@wix.com>
@etamarw etamarw mentioned this pull request Oct 30, 2021
Merged
3 tasks
jeffhollan
jeffhollan approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@jeffhollan jeffhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great feature

zroubalik
zroubalik reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add rolloutStrategy entry to the ScaledJob Spec section at the begging of the page?
somewhere around line 43 (after maxReplicaCoutn and before scalingStrategy).

Thanks!

content/docs/2.5/concepts/scaling-jobs.md Outdated Show resolved Hide resolved
@etamarw @zroubalik
Update content/docs/2.5/concepts/scaling-jobs.md
cec5a9d 
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: etamarw <etamarw@wix.com>
zroubalik
zroubalik approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @etamarw !

@zroubalik zroubalik merged commit 5daa8bb into kedacore:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@jeffhollan jeffhollan jeffhollan approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etamarw @zroubalik @jeffhollan