Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the support of maxSessions in selenium grid scaler #716

Merged

Conversation

adborroto
Copy link
Contributor

Signed-off-by: Alejandro Dominguez adborroto90@gmail.com

Update the documentation to mention that grid maxSession is consider when scaling Selenium Grid. Currently, the Selenium Grid Scaler of KEDA ignoring the maxSessions per node.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes 2618

Signed-off-by: Alejandro Dominguez <adborroto90@gmail.com>
@netlify
Copy link

netlify bot commented Mar 18, 2022

❌ Deploy Preview for keda failed.

🔨 Explore the source changes: 961d59b

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/623473ed273e6a0008f1c9af

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this! ❤️ ❤️ ❤️ ❤️

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JorTurFer JorTurFer merged commit 0f80162 into kedacore:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selenium Grid Scaler should consider "maxSession"
3 participants