-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add a note on scalers which support float target value #783
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2be6226
to
0991acc
Compare
0991acc
to
9fd4dfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an end-user, how much do I care about this? If I do, might need some more background on what this means maybe? Scaler typically does the heavy lifting on this and in some scalers this does not make sense - For example, I won't be scaling for 30.5 messages.
Maybe it's better to update the scalers where this is useful?
you are right, on it specifying the parameters which accepts floats BTW, all the scalers in this PR support float 😄 |
9fd4dfa
to
9e7b507
Compare
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
9e7b507
to
6af7818
Compare
They do support it, but does it make sense? :D Anyway it's up to them but for SB it's less relevant |
Yes, the scalers inclued in this PR support float because it's relevant. |
@zroubalik , does this match with your expectations too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for this!
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
After merging the PR to support
mili
unit in core, there are some scalers that supportfloat
as target value (because the scaler logic already supported float64 and it made sense).Checklist
Related kedacore/keda#3135