Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding changes for configuring unsafe ssl for self signed certs use case for Prometheus scalar #913

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

mayurvaid-redvest
Copy link
Contributor

@mayurvaid-redvest mayurvaid-redvest commented Aug 25, 2022

Signed-off-by: mayurvaid-redvest 109327850+mayurvaid-redvest@users.noreply.github.com

We need to have a flag which allows unsafeSSL flag to be set when you have self signed certs for prometheus endpoints

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: mayurvaid-redvest <109327850+mayurvaid-redvest@users.noreply.github.com>
@mayurvaid-redvest mayurvaid-redvest requested a review from a team as a code owner August 25, 2022 11:55
@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 5faa656
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6308a0d09615d600096d8f14
😎 Deploy Preview https://deploy-preview-913--keda.netlify.app/docs/2.9/scalers/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tomkerkhove
Copy link
Member

Hi, can you provide a more descriptive PR title & description please?

@mayurvaid-redvest mayurvaid-redvest changed the title Update prometheus.md Adding changes for configuring unsafe ssl for self signed certs use case for Prometheus scalar Aug 25, 2022
…ase for Prometheus scalar

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: mayurvaid-redvest <109327850+mayurvaid-redvest@users.noreply.github.com>
@JorTurFer JorTurFer merged commit 20522b6 into kedacore:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants