Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Scaler): Add Loki Scaler Docs #948

Merged
merged 9 commits into from
Oct 20, 2022
Merged

docs(Scaler): Add Loki Scaler Docs #948

merged 9 commits into from
Oct 20, 2022

Conversation

neelanjan00
Copy link
Contributor

@neelanjan00 neelanjan00 commented Sep 27, 2022 •
edited by tomkerkhove
Loading

Signed-off-by: Neelanjan Manna neelanjan.manna@harness.io

Provide a description of what has been changed

  • Adds Loki scaler docs to v2.9

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#3699

@neelanjan00
added loki scaler docs
3eaacaf 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00
added bearer auth
6fba541 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00 neelanjan00 requested a review from a team as a code owner September 27, 2022 17:40
@netlify
Copy link

netlify bot commented Sep 27, 2022 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit bfbdd61
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6347eb3cdfc5580008d6c1ba
😎 Deploy Preview https://deploy-preview-948--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@neelanjan00 neelanjan00 mentioned this pull request Sep 27, 2022
Merged
5 tasks
tomkerkhove
tomkerkhove reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions

content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
@neelanjan00
added bearer auth description, fixed version availability
f7c52fb 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00
updated authMode parameter in the parameter list
efe785d 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00
updated auth parameter description
5ad780d 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
tomkerkhove
tomkerkhove approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting for feature to merge

JorTurFer
JorTurFer reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only some comments inline

content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
@neelanjan00
updated tenantName parameter
2596f74 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
v-shenoy
v-shenoy suggested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor discrepancies I noticed between the code changes and the docs.

content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
content/docs/2.9/scalers/loki.md Outdated Show resolved Hide resolved
@neelanjan00
fixed authModes
88cde01 
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00
Merge branch 'main' into loki-scaler
bfbdd61
@neelanjan00 neelanjan00 requested a review from v-shenoy October 13, 2022 10:41
@JorTurFer JorTurFer merged commit 76dc6e1 into kedacore:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-shenoy v-shenoy v-shenoy approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neelanjan00 @tomkerkhove @JorTurFer @v-shenoy