Switch from keda build-tools image to keda-tools image #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joel Smith <joelsmith@redhat.com>
Signed-off-by: Joel Smith <joelsmith@redhat.com>
Signed-off-by: Joel Smith <joelsmith@redhat.com>
jkyros
approved these changes
Feb 20, 2024
| done | ||
|
|
||
| # hack: force version of openshift API module based upon k8s->openshift version skew (e.g. 1.27 -> 4.14) | ||
| openshift_branch="release-4.$(($(echo $k8sver | sed 's/v0\.\([0-9]*\)\.[0-9]*$/\1/')-13))" |
There was a problem hiding this comment.
I've always wished there was a canonical file somewhere in github that had the openshift:kube version mapping, but I don't know of one either. I think -13 (or +2.87 ) is reasonable for now as long as it holds and we can get away with it -- I'd rather do that than maintain our own mapping table here and adding the new version every time we do the release.
There was a problem hiding this comment.
Okay, thanks for being a sounding board on this. I think I'm leaning in the same direction. Probably once it breaks, we'll notice when we try to build with an incompatibly-skewed version, and that can be our cue to fix the skew magic number.
Signed-off-by: Joel Smith <joelsmith@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes related to builds and the release process, plus a bonus, unrelated docs fix:
hacks/relprep.shdetect and use the same version of k8s libraries as KEDA is using, for a given version (See Bump Go deps to be in sync with KEDA 2.13.0 (use the same k8s version) #215 )Checklist
Fixes #215