Fix keda-metrics-apiserver ServiceMonitor port #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our 2.11.2 release we retired the old 9022 metrics port, which was superseded by port 8080. We updated the service with the port name "metrics", but it looks like we missed updating the ServiceMonitor, which still had it listed as "http" -- resulting in the prometheus target not working. This updates the ServiceMonitor so the port name matches the service, and the tubes are properly connected and "metrics" will be a valid prometheus target for keda-metrics-apiserver. Signed-off-by: John Kyros <jkyros@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our 2.11.2 release #205 we:
9022metrics port, and replaced it with8080, the old http port.However:
keda-metrics-apiserverisn't working because it can't find a port named "http" anymore.Therefore:
Checklist
Fixes #