Use input metric name consistently when reporting Job metrics (#984)

Signed-off-by: Nikhil Bhargava <993682+nbhargava@users.noreply.github.com>
kedacore · Aug 11, 2020 · bcc7526 · bcc7526
1 parent ff053e0
commit bcc7526
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/pkg/scalers/cron_scaler.go b/pkg/scalers/cron_scaler.go
@@ -18,7 +18,6 @@ import (
 
 const (
 	defaultDesiredReplicas = 1
-	cronMetricName         = "ReplicaCount"
 	cronMetricType         = "External"
 )
 
@@ -169,7 +168,7 @@ func (s *cronScaler) GetMetrics(ctx context.Context, metricName string, metricSe
 
 	/*******************************************************************************/
 	metric := external_metrics.ExternalMetricValue{
-		MetricName: cronMetricName,
+		MetricName: metricName,
 		Value:      *resource.NewQuantity(currentReplicas, resource.DecimalSI),
 		Timestamp:  metav1.Now(),
 	}

diff --git a/pkg/scalers/postgresql_scaler.go b/pkg/scalers/postgresql_scaler.go
@@ -15,7 +15,6 @@ import (
 )
 
 const (
-	pgMetricName              = "num"
 	defaultPostgreSQLPassword = ""
 )
 
@@ -213,7 +212,7 @@ func (s *postgreSQLScaler) GetMetrics(ctx context.Context, metricName string, me
 	}
 
 	metric := external_metrics.ExternalMetricValue{
-		MetricName: pgMetricName,
+		MetricName: metricName,
 		Value:      *resource.NewQuantity(int64(num), resource.DecimalSI),
 		Timestamp:  metav1.Now(),
 	}

diff --git a/pkg/scalers/rabbitmq_scaler.go b/pkg/scalers/rabbitmq_scaler.go
@@ -258,7 +258,7 @@ func (s *rabbitMQScaler) GetMetrics(ctx context.Context, metricName string, metr
 	}
 
 	metric := external_metrics.ExternalMetricValue{
-		MetricName: rabbitQueueLengthMetricName,
+		MetricName: metricName,
 		Value:      *resource.NewQuantity(int64(messages), resource.DecimalSI),
 		Timestamp:  metav1.Now(),
 	}