Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in a scaler during autoscaling is not properly logged and ScaledObject.Status.Ready is not properly set #2603

Closed
zroubalik opened this issue Feb 7, 2022 · 0 comments · Fixed by #2604
Labels
bug Something isn't working
Milestone

Comments

@zroubalik
Copy link
Member

zroubalik commented Feb 7, 2022

Report

Problem in a scaler during autoscaling is not properly logged and ScaledObject.Status.Ready is not properly set.

Expected Behavior

If all triggers defined in ScaledObject are failing-> set status to "ConditionFalse" "TriggerError" "Triggers defined in ScaledObject are not working correctly"

If mutliple trigger defined in ScaledObject and only some are failing -> set status to "ConditionUnknown" "PartialTriggerError" "Some triggers defined in ScaledObject are not working correctly"

Print relevant error in the INFO log level in KEDA operator logs

Actual Behavior

Status remains "ConditionTrue" "ScaledObjectReady" "ScaledObject is defined correctly and is ready for scaling"

Nothing is logged in INFO level (only in DEBUG) and if there are mutliple triggers, only the error in the first trigger is being logged.

Steps to Reproduce the Problem

  1. ScaledObject with correct trigger(s) properly autoscaling
  2. The target service is down (eg Kafka Broker)
  3. Error in the trigger is not being reflected in ScaledObject.Status.Ready and in log

Logs from KEDA operator

No response

KEDA Version

2.6.0

Kubernetes Version

No response

Platform

No response

Scaler Details

No response

Anything else?

No response

@zroubalik zroubalik added the bug Something isn't working label Feb 7, 2022
@zroubalik zroubalik added this to the v2.6.1 milestone Feb 7, 2022
@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
Repository owner moved this from Backlog to Ready To Ship in Roadmap - KEDA Core Feb 10, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
1 participant