Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly log and set correct status if any of ScaleObject's triggers are in error state #2604

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Properly log and set correct status if any of ScaleObject's triggers are in error state #2604

merged 1 commit into from
Feb 10, 2022

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Feb 7, 2022 •
edited
Loading

Images with this fix + fix from #2593 are hosted here:

  • quay.io/zroubalik/keda:statusFix
  • quay.io/zroubalik/keda-metrics-apiserver:statusFix

Checklist

Fixes #2603

@zroubalik zroubalik requested a review from a team as a code owner February 7, 2022 23:38
@zroubalik zroubalik mentioned this pull request Feb 7, 2022
Closed
5 tasks
@zroubalik
Copy link
Member Author

zroubalik commented Feb 7, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

tomkerkhove
tomkerkhove approved these changes Feb 8, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scaling/executor/scale_scaledobjects.go Show resolved Hide resolved
JorTurFer
JorTurFer approved these changes Feb 8, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scaling/executor/scale_scaledobjects.go Show resolved Hide resolved
@zroubalik
Copy link
Member Author

zroubalik commented Feb 8, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member Author

zroubalik commented Feb 8, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member Author

zroubalik commented Feb 8, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member Author

zroubalik commented Feb 9, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 9, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 9, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@tomkerkhove
Copy link
Member

Nice work both of you! Are we good to merge?

@JorTurFer
Copy link
Member

Not yet.
For splitting tests fixing and this bug fixing I created another PR updating the failing tests.
Once that is merged, @zroubalik will rebase his branch and then it's ready

@JorTurFer
Copy link
Member

This is the PR fixing tests #2620

properly log and set correct status if any of ScaleObject's triggers …
05410af 
…are in error state

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
Copy link
Member Author

zroubalik commented Feb 10, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 10, 2022 •
edited by github-actions bot
Loading

/run-e2e azure-pipelines.test*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 10, 2022 •
edited by github-actions bot
Loading

/run-e2e openstack-swift.test*
Update: You can check the progres here

@zroubalik zroubalik merged commit 10db6e1 into kedacore:main Feb 10, 2022
This was referenced Feb 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zroubalik @JorTurFer @tomkerkhove