Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Data Explorer: iter.Next is deprecated: Use NextRowOrError() instead #2989

Closed
zroubalik opened this issue May 3, 2022 · 3 comments · Fixed by #2991
Closed

Azure Data Explorer: iter.Next is deprecated: Use NextRowOrError() instead #2989

zroubalik opened this issue May 3, 2022 · 3 comments · Fixed by #2991
Assignees
Labels
bug Something isn't working

Comments

@zroubalik
Copy link
Member

zroubalik commented May 3, 2022

Report

Azure Data Explorer code needs to be updated, I have set an exception to the .golangci.yaml in the meantime:

# remove once https://github.com/kedacore/keda/issues/2989 is fixed

make golangci                                                                                                                                                           
golangci-lint run
pkg/scalers/azure/azure_data_explorer.go:95:14: SA1019: iter.Next is deprecated: Use NextRowOrError() instead for more robust error handling. In a future version, this will be removed, and NextRowOrError will replace it. Next gets the next Row from the query. io.EOF is returned if there are no more entries in the output. This method will fail on errors inline within the rows, even though they could potentially be recovered and more data might be available. Once Next() returns an error, all subsequent calls will return the same error. (staticcheck)
        row, err := iter.Next()
                    ^
pkg/scalers/azure/azure_data_explorer.go:105:11: SA1019: iter.Next is deprecated: Use NextRowOrError() instead for more robust error handling. In a future version, this will be removed, and NextRowOrError will replace it. Next gets the next Row from the query. io.EOF is returned if there are no more entries in the output. This method will fail on errors inline within the rows, even though they could potentially be recovered and more data might be available. Once Next() returns an error, all subsequent calls will return the same error. (staticcheck)
        _, err = iter.Next()

Expected Behavior

golangci pass without an expection

Actual Behavior

iter.Next is deprecated

Steps to Reproduce the Problem

  1. make golangci

Logs from KEDA operator

No response

KEDA Version

No response

Kubernetes Version

No response

Platform

No response

Scaler Details

No response

Anything else?

No response

@zroubalik zroubalik added the bug Something isn't working label May 3, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core May 3, 2022
@zroubalik zroubalik moved this from Proposed to To Do in Roadmap - KEDA Core May 3, 2022
@zroubalik zroubalik changed the title Azure Data Explorer: Azure Data Explorer: iter.Next is deprecated: Use NextRowOrError() instead May 3, 2022
@JorTurFer
Copy link
Member

I think that this PR is needed before to have the updated dependency

@zroubalik
Copy link
Member Author

Yeah, I will update this one once it is merged. I needed a link to an issue in the PR chicken-egg problem 😄

@JorTurFer JorTurFer self-assigned this May 3, 2022
@zroubalik
Copy link
Member Author

This needs to be updated once is this issue solved

# remove once https://github.com/kedacore/keda/issues/2989 is fixed

@JorTurFer JorTurFer moved this from To Do to In Review in Roadmap - KEDA Core May 3, 2022
Repository owner moved this from In Review to Ready To Ship in Roadmap - KEDA Core May 3, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants