Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update data explorer scaler to fix deprecation #2991

Merged
merged 5 commits into from
May 3, 2022

Conversation

JorTurFer
Copy link
Member

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #2989

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner May 3, 2022 17:41
@JorTurFer
Copy link
Member Author

JorTurFer commented May 3, 2022

/run-e2e azure-data*
Update: You can check the progres here

JorTurFer added 2 commits May 3, 2022 19:51
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 3, 2022

/run-e2e azure-data*
Update: You can check the progres here

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 3, 2022

/run-e2e azure-data*
Update: You can check the progres here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer merged commit ea3b2e1 into kedacore:main May 3, 2022
@JorTurFer JorTurFer deleted the fix-deprecation branch May 3, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Data Explorer: iter.Next is deprecated: Use NextRowOrError() instead
2 participants