Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very mush connection created by keda #3874

Closed
penghuazhou opened this issue Nov 17, 2022 · 2 comments
Closed

Very mush connection created by keda #3874

penghuazhou opened this issue Nov 17, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@penghuazhou
Copy link
Contributor

penghuazhou commented Nov 17, 2022

Report

When i have 600 scaledobject, every scaledobject have a prometheus trigger, it have create more than 500 http connection.We can set disableKeepAlives to be false when create client,as hpa only have only little goroutine to get metrics.

image

Expected Behavior

image

Actual Behavior

image

Steps to Reproduce the Problem

  1. 600 scaledobject, every scaledobject have a prometheus trigger

KEDA Version

2.8.1

Kubernetes Version

1.20.11

@penghuazhou penghuazhou added the bug Something isn't working label Nov 17, 2022
@JorTurFer
Copy link
Member

JorTurFer commented Nov 17, 2022

Hello @penghuazhou
AFAIK, the HPA Controller soon will work in parallel, but you are right, enforce the keep alive isn't worth and having the option to configure it (enabling or disabling it) could fit better in more scenarios.
Are you willing to contribute with the improvement?

@penghuazhou
Copy link
Contributor Author

penghuazhou commented Nov 18, 2022

@JorTurFer, I have commit a pr, #3878

@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Nov 28, 2022
@tomkerkhove tomkerkhove moved this from Proposed to In Review in Roadmap - KEDA Core Nov 28, 2022
Repository owner moved this from In Review to Ready To Ship in Roadmap - KEDA Core Dec 9, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants