Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not keep alive http connection #3878

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Do not keep alive http connection #3878

merged 2 commits into from
Nov 28, 2022

Conversation

penghuazhou
Copy link
Contributor

@penghuazhou penghuazhou commented Nov 18, 2022 •
edited
Loading

Signed-off-by: penghuazhou 1021556870@qq.com

Provide a description of what has been changed

Checklist

Relates to #3874

@penghuazhou penghuazhou requested a review from a team as a code owner November 18, 2022 03:09
@penghuazhou penghuazhou mentioned this pull request Nov 18, 2022
Closed
JorTurFer
JorTurFer reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, I left a comment inline

pkg/util/http.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

BTW, in order to be able to merge this, we need some things:

Does it make sense to add this new env variable to helm chart parameters?

@penghuazhou
Support disable keep http connection alive
5297adb 
Signed-off-by: penghuazhou <1021556870@qq.com>
@penghuazhou
Merge branch 'main' into fix/httpclient
d74797d 
# Conflicts:
#	CHANGELOG.md
@tomkerkhove tomkerkhove mentioned this pull request Nov 28, 2022
Merged
3 tasks
@zroubalik
Copy link
Member

zroubalik commented Nov 28, 2022 •
edited by github-actions bot
Loading

/run-e2e aws*
Update: You can check the progress here

@tomkerkhove tomkerkhove merged commit cfc294b into kedacore:main Nov 28, 2022
@zroubalik
Copy link
Member

@tomkerkhove docs are not ready yet kedacore/keda-docs#982

@JorTurFer
Copy link
Member

This feature was waiting docs and chart

josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@penghuazhou @josephangbc
Do not keep alive http connection (kedacore#3878)
2b45351
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@penghuazhou @josephangbc
Do not keep alive http connection (kedacore#3878)
dad43c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@penghuazhou @JorTurFer @zroubalik @tomkerkhove