-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS sqs scaler to support scaleOnDelayed #4377
Comments
Hey @ding1992 |
I'll check it tomorrow |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. |
…ore#4377) Signed-off-by: Chris Taylor <chris@cronofy.com>
…ore#4377) Signed-off-by: Chris Taylor <chris@cronofy.com>
…ore#4377) Signed-off-by: Chris Taylor <chris@cronofy.com>
Proposal
Similar to scaleOnInFlight, it'd be appreciated if we could have scaleOnDelayed to indicate whether messageDelayed metric should be counted in to a trigger check.
Use Case
Our service consumes messages from SQS, queue them internally and deletes them from SQS immediately (we can't change this at the moment).
Hence it's possible that scale down would happen while the service is still processing the messages, because SQS is already empty.
We could set a longer cooldownPeriod (e.g. 30mins), but it's still possible that our service could consume and delete new messages between two polling checks (hence 30mins cool down is not refreshed).
If scaleOnDelayed is available, we could set delaySeconds = 10s when we add messages to the queue, and pollingInterval=5s.
This way 30mins cool down would always be refreshed when there is a new message.
Is this a feature you are interested in implementing yourself?
Maybe
Anything else?
No
The text was updated successfully, but these errors were encountered: