Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch created HPA and TriggerAuthentication resources #511

Closed
zroubalik opened this issue Dec 10, 2019 · 3 comments
Closed

Watch created HPA and TriggerAuthentication resources #511

zroubalik opened this issue Dec 10, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@zroubalik
Copy link
Member

ATM we don't watch HPA and TriggerAuthentication resources for changes/updates. Controller should watch those resources and reconcile.

@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Dec 10, 2019
@zroubalik zroubalik self-assigned this Dec 10, 2019
@tomkerkhove tomkerkhove added bug Something isn't working and removed feature-request All issues for new features that have not been committed to needs-discussion labels Dec 11, 2019
@tomkerkhove
Copy link
Member

Thanks for taking a look at this @zroubalik!

@zroubalik
Copy link
Member Author

HPAs should be covered by #581

We still need to figure out TriggerAuthentication

@zroubalik
Copy link
Member Author

As TriggerAuthentication object could be shared between multiple ScaledObject reconciling it doesn't make a sense.

preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
* update 2.x azure storage blob triggers

Signed-off-by: Joachim Goris <gorisjoachim@hotmail.com>

* forgot a period at a sentence

Signed-off-by: Joachim Goris <gorisjoachim@hotmail.com>

* split PodIdentity

Signed-off-by: Joachim Goris <gorisjoachim@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants