make deploy shouldn't enable opentelemetry by default

[zroubalik]

Proposal

make deploy is usually used for development purposes of KEDA. With some recent changes, if one run this command, KEDA is configured to enable opentelemery collector.

We should revisit this approach and don't enforce opentelemetry usage. make deploy is also used to run e2e tests in our infra - there is enabling the opentelemetry collector expected.

keda/tests/utils/setup_test.go

Line 220 in 5648b57

out, err := ExecuteCommandWithDir("make deploy", "../..")

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

[SpiritZhou]

I think we can add a flag like AZURE_RUN_AAD_POD_IDENTITY_TESTS to enable/disable opentelemetry.

[zroubalik]

I think more generic flag like ENABLE_OPENTELEMETRY might be better. I am okay with enabling OTEL for all e2e tests in CI, but would like to disable this by default for local development with make deploy.