New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ENABLE_OPENTELEMETRY flag #5436

Merged

zroubalik merged 4 commits into kedacore:main from SpiritZhou:spiritzhou/opentelemetryflag

Feb 20, 2024

Contributor

SpiritZhou commented Jan 26, 2024

Add the ENABLE_OPENTELEMETRY flag to control the installation of OpenTelemetry during the deployment or testing process.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes ##5375

SpiritZhou requested a review from a team as a code owner

January 26, 2024 03:38

SpiritZhou requested a review from zroubalik

January 26, 2024 03:39

JorTurFer reviewed

View reviewed changes

.github/workflows/pr-e2e.yml Outdated Show resolved Hide resolved

SpiritZhou mentioned this pull request

Edit e2e test YAML before merging #5436 #5439

Merged

3 tasks

JorTurFer pushed a commit that referenced this pull request


          Edit e2e test YAML before merging #5436 (#5439)

f439f17

* Update

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

* Update

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

---------

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Member

JorTurFer commented Jan 29, 2024 •

edited by github-actions bot

Loading

/run-e2e opentelemetry
Update: You can check the progress here

zroubalik reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Member

JorTurFer commented Jan 29, 2024 •

edited by github-actions bot

Loading

/run-e2e opentelemetry
Update: You can check the progress here

Contributor Author

SpiritZhou commented Jan 30, 2024

My local testing works fine, and I added some logs for checking. Could you help to run e2e test again? @JorTurFer

Member

tomkerkhove commented Jan 30, 2024 •

edited by github-actions bot

Loading

/run-e2e opentelemetry
Update: You can check the progress here

zroubalik reviewed

View reviewed changes

pkg/scaling/cache/scalers_cache.go Outdated Show resolved Hide resolved

Contributor Author

SpiritZhou commented Feb 1, 2024

Removed debugging log in scaler_cache.go


          Update on spiritzhou/opentelemetryflag

c712551

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou force-pushed the spiritzhou/opentelemetryflag branch from 31df77d to c712551 Compare

February 2, 2024 02:34


          Merge branch 'main' into spiritzhou/opentelemetryflag

2d2653a

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Member

tomkerkhove commented Feb 5, 2024 •

edited by github-actions bot

Loading

/run-e2e opentelemetry
Update: You can check the progress here

JorTurFer approved these changes

View reviewed changes

Member

JorTurFer commented Feb 6, 2024

Could you fix the conflict?

SpiritZhou added 2 commits

February 18, 2024 10:06


          Merge branch 'main' into spiritzhou/opentelemetryflag

9db985c

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Fix

87c8c96

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Member

zroubalik commented Feb 19, 2024 •

edited by github-actions bot

Loading

/run-e2e opentelemetry
Update: You can check the progress here

zroubalik reviewed

View reviewed changes

Member

zroubalik left a comment

We should add ENABLE_OPENTELEMETRY = true to GH Secrets, right?

Member

tomkerkhove commented Feb 19, 2024

This is not a secret though, so let's add it to variables to not mask the value

zroubalik reviewed

View reviewed changes

Member

zroubalik left a comment

LGTM, thanks!

zroubalik merged commit b3f5548 into kedacore:main

21 checks passed

joelsmith mentioned this pull request

Fix e2e test in non-opentelemetry case #5578

Merged

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet