-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres scaler #553
Postgres scaler #553
Conversation
8a2faeb
to
345a312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dimberman. The change looks good to me. I have a couple of minor comments from just looking at the code.
345a312
to
c521932
Compare
Thank you @ahmelsayed I have addressed your comments |
@ahmelsayed Late to the game but something I'd keep an eye open for the future is:
Not criticizing, just taking mental note for the future ones as we might want to align them a bit more but should've reviewed as well - Sorry! |
… `feature-request` (kedacore#553) Signed-off-by: GitHub <noreply@github.com>
No description provided.