Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres scaler #553

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Postgres scaler #553

merged 1 commit into from
Jan 23, 2020
+238 −16

Conversation

dimberman
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Jan 21, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@dimberman dimberman requested a review from jeffhollan January 21, 2020 17:14
ahmelsayed
ahmelsayed reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dimberman. The change looks good to me. I have a couple of minor comments from just looking at the code.

@dimberman
Copy link
Contributor Author

Thank you @ahmelsayed I have addressed your comments

@dimberman dimberman requested a review from ahmelsayed January 22, 2020 23:56
@ahmelsayed ahmelsayed merged commit 1b38a7f into kedacore:master Jan 23, 2020
@tomkerkhove tomkerkhove mentioned this pull request Jan 23, 2020
Closed
@tomkerkhove
Copy link
Member

@ahmelsayed Late to the game but something I'd keep an eye open for the future is:

  1. Consistency - Here it's called connStr, others use connection and probably have more ways of configuring same thing with different name
  2. Scaler is called postgres rather than postgreSQL, is that how it's typically called?

Not criticizing, just taking mental note for the future ones as we might want to align them a bit more but should've reviewed as well - Sorry!

preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
@tomkerkhove
chore: Change feature as allowed label for stale issues, instead of…
304c964 
… `feature-request` (kedacore#553)

Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimberman @msftclas @tomkerkhove @ahmelsayed @astro-sql-decorator