Update operator to support the WATCH_NAMESPACE env var #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colton Herinckx <herinckc@gmail.com>
Signed-off-by: Colton Herinckx <herinckc@gmail.com>
|
Are you up for sending a PR to https://github.com/kedacore/charts as well please? |
|
@tomkerkhove charts should worked as they imho use this ENV variable. This was working before, but probably was mistakenly omitted when we were doing the big update recently. |
Signed-off-by: Colton Herinckx <herinckc@gmail.com>
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
* add support to the operator for the WATCH_NAMESPACE env var Signed-off-by: Colton Herinckx <herinckc@gmail.com> * update the changelog Signed-off-by: Colton Herinckx <herinckc@gmail.com> * address PR comments - add PR number and link to changelog Signed-off-by: Colton Herinckx <herinckc@gmail.com>
|
how to set multiple namespaces? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Colton Herinckx herinckc@gmail.com
This PR adds operator support for the
WATCH_NAMESPACEenvironment variable; while the adapter currently supports this env var it seems as though the operator itself does notLet me know if I need to update any tests or docs along with this PR. I didn't see any operator-specific tests or any mention of the
WATCH_NAMESPACEenv var in the keda-docs repo so I haven't done anything for either of those tasks but I'm happy to make more changes if I've missed anythingAddresses #601 (comment)
Checklist